Skip to content

Implement IsValueInlinedInExistentialContainer #40053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2021
Merged

Implement IsValueInlinedInExistentialContainer #40053

merged 1 commit into from
Nov 8, 2021

Conversation

augusto2112
Copy link
Contributor

Separate the code that finds if an existential container to its own function, so it can be used by LLDB.

@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112
Copy link
Contributor Author

llvm::Optional<bool> looks like a code smell, but most functions in MetadataReader return an optional of some type, where the None indicates failure to read data, so I decided to keep keep that in the signature.

@mikeash
Copy link
Contributor

mikeash commented Nov 4, 2021

LGTM. If you feel like getting fancier with the return value, I've started using std::pair<llvm::Optional<std::string>, ReturnType> where the optional string contains an error message on failure. Just an idea, don't feel like you have to, especially if clients wouldn't take advantage of it.

adrian-prantl
adrian-prantl approved these changes Nov 4, 2021
View reviewed changes
include/swift/Remote/MetadataReader.h Outdated
@@ -690,6 +690,28 @@ class MetadataReader {
RemoteAddress(StartOfValue));
}

/// Given a known-opaque existential, discover if it's value is inlined in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: it's -> its

slavapestov
slavapestov reviewed Nov 5, 2021
View reviewed changes
include/swift/Remote/MetadataReader.h Outdated
/// Given a known-opaque existential, discover if it's value is inlined in
// the existential container.
llvm::Optional<bool>
IsValueInlinedInExistentialContainer(RemoteAddress ExistentialAddress) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function names begin with a lowercase letter in Swift

@augusto2112 augusto2112 force-pushed the is-in-existential-container branch from c6866a2 to 0eb09d9 Compare November 5, 2021 16:34
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112 augusto2112 mentioned this pull request Nov 5, 2021
Merged
adrian-prantl
adrian-prantl reviewed Nov 5, 2021
View reviewed changes
include/swift/Remote/MetadataReader.h Outdated
@@ -690,6 +690,28 @@ class MetadataReader {
RemoteAddress(StartOfValue));
}

/// Given a known-opaque existential, discover if its value is inlined in
// the existential container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use /// comments for the entire doxygen comment. I'm not sure if this is actually necessary, but at least it looks more consistent.

@augusto2112 augusto2112 force-pushed the is-in-existential-container branch from 0eb09d9 to 1336d2b Compare November 5, 2021 19:05
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112 augusto2112 merged commit 9c5e5ef into swiftlang:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

@mikeash mikeash mikeash approved these changes

@adrian-prantl adrian-prantl adrian-prantl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@augusto2112 @mikeash @slavapestov @adrian-prantl