[CodeComplete] Markup default arguments #40351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
force-pushed
the
annotate-default-args
branch
2 times, most recently
from
6bbf33e to
fae72ab
Compare
bnbarham
changed the title
|
@swift-ci please test |
|
Windows failure is known (and that test since disabled). |
rintaro
reviewed
Dec 10, 2021
bnbarham
force-pushed
the
annotate-default-args
branch
from
fae72ab to
5f701c2
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please clean test macOS platform |
rintaro
reviewed
Dec 14, 2021
|
@swift-ci please test |
bnbarham
force-pushed
the
annotate-default-args
branch
from
5f701c2 to
2ca304e
Compare
|
Build failed |
|
@swift-ci please clean test macOS platform |
|
Build failed |
Add `<callarg.default />` nodes to the annotated description of a completion result for all arguments that have defaults. Resolves rdar://85904660.
Now that arguments are marked up with whether they have a default or not, clients may not need the extra call (that has no default arguments). Add an option to allow not adding this item. Resolves rdar://85526214.
bnbarham
force-pushed
the
annotate-default-args
branch
from
2ca304e to
65ef802
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
<callarg.default />nodes to the annotated description of acompletion result for all arguments that have defaults.
Also add a new option to control whether or not an extra item is added
for calls with no default arguments or not (since clients can now use
the marked up argument to check this themselves).