Skip to content

[SwiftSyntax] Remove default empty string in Token's text #40359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Dec 1, 2021

@kimdv
Copy link
Contributor Author

kimdv commented Dec 2, 2021

swiftlang/swift-syntax#341

@swift-ci Please smoke test

@kimdv kimdv requested a review from ahoppen December 2, 2021 17:01
@kimdv kimdv force-pushed the kimdv/add-asserts-in-inits branch from 3da379b to 29bc4e3 Compare December 2, 2021 18:51
@kimdv kimdv force-pushed the kimdv/add-asserts-in-inits branch from 29bc4e3 to ba77a58 Compare December 2, 2021 18:53
@kimdv
Copy link
Contributor Author

kimdv commented Dec 2, 2021

swiftlang/swift-syntax#341

@swift-ci Please smoke test

@kimdv kimdv changed the title [SwiftSyntax] Add doc that we relay on this behaviour [SwiftSyntax] Remove default empty string in Token's text Dec 2, 2021
@kimdv
Copy link
Contributor Author

kimdv commented Dec 3, 2021

swiftlang/swift-syntax#341

@swift-ci Please smoke test MacOS

@kimdv
Copy link
Contributor Author

kimdv commented Dec 3, 2021

@ahoppen the CI for MacOS did fail yesterday evening and now it passed?
Am I good to go?

@ahoppen
Copy link
Member

ahoppen commented Dec 3, 2021

Yes, if CI passed you can merge.

@kimdv kimdv merged commit 14d8c19 into swiftlang:main Dec 3, 2021
@kimdv kimdv deleted the kimdv/add-asserts-in-inits branch December 3, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants