Modify reflection dumping to use std::ostream instead of FILE * #40452
Conversation
|
@swift-ci smoke test |
| void MetadataSource::dump() const { | ||
| dump(stderr, 0); | ||
| } | ||
| void MetadataSource::dump() const { dump(std::cout, 0); } |
There was a problem hiding this comment.
This, and various others, should be cerr to match the previous code, although I'm not sure offhand why we use one versus the other.
| auto oldFlags = stream.flags(); | ||
| stream << std::fixed << std::setprecision((int)fieldName.size()) | ||
| << fieldName.data(); | ||
| stream.flags(oldFlags); |
There was a problem hiding this comment.
C++ really makes this difficult, huh. I think stream.write() might be better here, even though it doesn't quite mean the same thing (since it won't stop at a NUL character).
| @@ -200,7 +201,7 @@ swift_reflection_addReflectionInfo(SwiftReflectionContextRef ContextRef, | |||
| || Info.capture.offset != 0 | |||
| || Info.type_references.offset != 0 | |||
| || Info.reflection_strings.offset != 0) { | |||
| fprintf(stderr, "reserved field in swift_reflection_info_t is not zero\n"); | |||
| std::cout << "reserved field in swift_reflection_info_t is not zero\n"; | |||
There was a problem hiding this comment.
This one should definitely be cerr.
There was a problem hiding this comment.
In a future patch we should upgrade this to do real error handling. Xcode users would not see anything printed to stderr when it happens in lldb-rpc-server.
There was a problem hiding this comment.
This is more of an assertion failure than an error, but better handling wouldn't be a bad thing.
augusto2112
force-pushed
the
refl-dump-use-stream
branch
from
cbada90 to
385d91a
Compare
|
@swift-ci test |
|
@swift-ci smoke test macOS |
This change is necessary so lldb can use typeref dumping facilities directly.