Skip to content

Conversation

gottesmm
Copy link
Contributor

We process these as loadable vars. This is really useful since it ensures that
uniqueness is preserved in this case:

  let x: [Enum]
  do {
      x = self.array
  }
  switch _move(x)[userHandle] {
  case .foo:
      assert(self.array._buffer.isUniquelyReferenced()))
  }

I added a test that proves this.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@gottesmm
Copy link
Contributor Author

I looked into the Linux failure! It is actually b/c we run DestroyHoisting. I am just going to manually disable DestroyHoisting on this test since eventually we are going to run it not in the mandatory pipeline and that is what I am testing here.

…an initial value.

We process these as loadable vars. This is really useful since it ensures that
uniqueness is preserved in this case:

```
  let x: K2
  do {
      x = self.k2
  }
  switch _move(x)[userHandle] {
  case .foo:
      assert(_isUnique(&self.k2))
  }
```

I added a test that proves this.
@gottesmm gottesmm force-pushed the pr-eeef8aba159ca25987b89cc791a4847eb32fc2a6 branch from 393937f to 396f510 Compare December 11, 2021 08:18
@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 396f510

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 396f510

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 396f510

@gottesmm
Copy link
Contributor Author

The smoke test signal bot timed out @najacque . I think if I just smoke test it should be fine.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@gottesmm
Copy link
Contributor Author

The actual linux test succeeded though, so I fixed the failed test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 396f510

@gottesmm
Copy link
Contributor Author

MacOS timed out as well

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test macOS platform

@gottesmm gottesmm merged commit 856ce2d into swiftlang:main Dec 12, 2021
@gottesmm gottesmm deleted the pr-eeef8aba159ca25987b89cc791a4847eb32fc2a6 branch December 12, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants