Skip to content

[NFC] Tweaked SILOptions fields for copy propagation. #40539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Replaced the quad-state (of state which one was illegal) of two booleans (EnableCopyPropagation and DisableCopyPropagation) with an enum.

@nate-chandler nate-chandler requested a review from atrick December 14, 2021 01:36
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

Diagnose passing both -enable-copy-propagation and
-disable-copy-propagation.
Replaced the quad-state (of state which one was illegal) of two booleans
(EnableCopyPropagation and DisableCopyPropagation) with an enum.
In preparation to change the default values, specify explicitly what
they are.
@nate-chandler nate-chandler force-pushed the copy_propagation/rename-options branch from 48d27ee to 478136d Compare December 14, 2021 01:44
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me. In my mind, separate enable/disable options are clear enough, but that's just me. The middle state, neither always on or always off is transitionary

@nate-chandler nate-chandler merged commit 660929d into swiftlang:main Dec 14, 2021
@nate-chandler nate-chandler deleted the copy_propagation/rename-options branch December 14, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants