Skip to content

Sendable fixes 5.6 #40624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2021
Merged

Sendable fixes 5.6 #40624

merged 2 commits into from
Dec 19, 2021

Conversation

DougGregor
Copy link
Member

  • Explicit Sendable conformances for @Frozen types (rdar://86496341)
  • Allow SwiftFoundation to declare NSObject, too (rdar://86495060)

@DougGregor
Explicit Sendable conformances for @frozen types
743aa79 
Task groups and `UnsafeCurrentTask` are non-`Sendable`.
`UnownedSerialExecutor` is always `Sendable`.

Fixes rdar://86496341.

(cherry picked from commit 400404c)
@DougGregor
Allow SwiftFoundation to declare NSObject, too
78aa68e 
Fixes rdar://86495060.

(cherry picked from commit fd41366)
@DougGregor
Copy link
Member Author

@swift-ci please test

ktoso
ktoso approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Doug!

@DougGregor DougGregor merged commit 6275f24 into swiftlang:release/5.6 Dec 19, 2021
@DougGregor DougGregor deleted the sendable-fixes-5.6 branch December 19, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @ktoso