build: allow building libswift for Windows #40637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no special environment variable to be set, the dlls must be co-located or be found in `Path`.
|
CC: @eeckstein |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
eeckstein
reviewed
Dec 20, 2021
| @@ -744,8 +744,6 @@ function(_compile_swift_files | |||
| set(set_environment_args "${CMAKE_COMMAND}" "-E" "env" "DYLD_LIBRARY_PATH=${bs_lib_dir}") | |||
| elseif(SWIFT_HOST_VARIANT_SDK MATCHES "LINUX|ANDROID|OPENBSD") | |||
| set(set_environment_args "${CMAKE_COMMAND}" "-E" "env" "LD_LIBRARY_PATH=${bs_lib_dir}") | |||
| else() | |||
| message(FATAL_ERROR "TODO: bootstrapping support for ${SWIFT_HOST_VARIANT_SDK}") | |||
There was a problem hiding this comment.
dlls must be co-located or be found in Path.
That means you have to copy the stdlib dlls, or set the PATH, right?
There was a problem hiding this comment.
Correct. But changing the Path is going to be very tricky here. Fortunately, the dlls are emitted next to the binaries on Windows already :)
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no special environment variable to be set, the dlls must be
co-located or be found in
Path.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.