Skip to content

Minor latent bug fix in findGuaranteedReferenceRoots. #41010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jan 26, 2022

Fix an obvious mistake that happens to not break anything in practice.

Note that the argument index of a terminator result is not the same as
an operand index for the terminator instruction.

@atrick atrick requested a review from nate-chandler January 26, 2022 00:42
@atrick
Copy link
Contributor Author

atrick commented Jan 26, 2022

@swift-ci smoke test

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@atrick atrick changed the title Minor lateny bug fix in findGuaranteedReferenceRoots. Minor latent bug fix in findGuaranteedReferenceRoots. Jan 26, 2022
Fix an obvious mistake that happens to not break anything in practice.

Note that the argument index of a terminator result is not the same as
an operand index for the terminator instruction.
@atrick
Copy link
Contributor Author

atrick commented Jan 26, 2022

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 952f2c6 into swiftlang:main Jan 26, 2022
@atrick atrick deleted the fix-findroot branch April 12, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants