Add a new virtual function to MemoryReader: resolvePointerAsSymbol #41072
Conversation
This new function allows subclasses to attempt to resolve a pointer to a symbol before any memory is read, which can be potentially expensive (for example, in LLDB).
|
@swift-ci smoke test |
|
|
||
| /// Atempt to resolve the pointer to a symbol for the given remote address. | ||
| virtual llvm::Optional<RemoteAbsolutePointer> | ||
| resolvePointerAsSymbol(RemoteAddress address) { |
There was a problem hiding this comment.
@adrian-prantl was your suggestion that we refactor the existing one? As is, this would give two functions that do the same.
There was a problem hiding this comment.
This variant works fine.
There was a problem hiding this comment.
Adrian do you mean we should add this new function and remove the old function?
The way I see it, the API doesn't need both resolvePointer and resolvePointerAsSymbol. I think this new one is the right way to model this behavior, and I think we can and should remove resolvePointer.
I also think we should attempt to give resolvePointerAsSymbol a better name. There's already getSymbolAddress, and as this function is the inverse, maybe it should be named getAddressSymbol. I think getSymbolForAddress might be most clear, but it would be confusing to have both getSymbolAddress and getSymbolForAddress. Maybe symbolForAddress?
This new function allows subclasses to attempt to resolve a pointer to
a symbol before any memory is read, which can be potentially expensive
(for example, in LLDB).
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.