[Distributed] Fix issues detected by ASAN #41155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit here is #41154 which will be meged in a moment I hope... |
|
@swift-ci asan test |
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-fix-asan-dist
branch
from
faa9414 to
ad14d02
Compare
xedin
approved these changes
Feb 2, 2022
|
@swift-ci asan test |
|
@swift-ci please test |
ktoso
commented
Feb 2, 2022
| continue; | ||
|
|
||
| return var; | ||
| } |
|
Linux failure was unrelated |
|
Tests passed but we want to try to reproduce if it isn't flaky. |
|
@swift-ci please test |
|
@swift-ci please test and merge |
|
resolves rdar://88228867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to resolve silly mistakes which actually were unsafe, thank you c++ 👋 😢
resolves rdar://88301320
Also unlocking all tests again to see if we good again here rdar://88228867