Lower non-optional executors #41194
Merged
Lower non-optional executors #41194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LowerHopToActor expected either an optional executor or an actor, and would crash when given a non-optional executor. This patch adds the wrapping to produce an optional executor from a non-optional executor in the pass to avoid crashing.
Adding test to crash SIL optimizer while lowering hops to executors.
etcwilde
added
the
concurrency
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
hop_to_executorinstruction to accept a non-optional executor without crashing in the lowering process.IRGen still expects an optional executor, so to "lower" the executor, we construct an optional around it.