Skip to content

[Distributed] Runtime: Add missing accessible function section registration on ELF #41307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2022
Merged

[Distributed] Runtime: Add missing accessible function section registration on ELF #41307

merged 2 commits into from
Feb 10, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 10, 2022

Resolves: rdar://87240034

@xedin xedin added the distributed Feature → concurrency: distributed actor label Feb 10, 2022
@xedin xedin requested a review from ktoso February 10, 2022 00:07
@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

@swift-ci please test Linux platform

ktoso
ktoso reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAT? That's the fix? Dear god.

@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

@swift-ci please test Windows platform

compnerd
compnerd reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make the appropriate change to the Windows path? (COFF)

@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

@compnerd Windows is XFail’ed for now due to other issues so ww cannot really test it yet, once that is dealt with I will verify that everything is properly registered.

@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

Actually, I am just going to open a PR add that on Windows as well, accessible functions aren’t in Swift-COFF.cpp

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4e8f962

@xedin
Copy link
Contributor Author

xedin commented Feb 10, 2022

@swift-ci please test macOS platform

@xedin xedin merged commit b5f4298 into swiftlang:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xedin @swift-ci @compnerd @ktoso