Add exported symbol on non-Apple platforms to enumerate MetadataSection structures at runtime. #41621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
grynspan
commented
Mar 2, 2022
mikeash
approved these changes
Mar 2, 2022
|
@swift-ci please smoke test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
2 times, most recently
from
2f42ef5 to
b7862c9
Compare
|
@swift-ci please test |
|
This is tremendously useful, thank you! |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
2 times, most recently
from
f8428e0 to
c1396c5
Compare
|
Changed the function from
|
|
@swift-ci please test |
mikeash
approved these changes
Mar 2, 2022
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
c1396c5 to
4a43a08
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
4df3d18 to
8648091
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
8648091 to
49c3750
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
49c3750 to
20b2166
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
20b2166 to
6352e14
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
6352e14 to
845904d
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
845904d to
cce4d06
Compare
|
@swift-ci please smoke test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
cce4d06 to
ec4c8e2
Compare
|
@swift-ci please smoke test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
ec4c8e2 to
1dc8b69
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
2 times, most recently
from
ff1806b to
0a87e61
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
0a87e61 to
bf1a309
Compare
|
Boy, |
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
bf1a309 to
a938de3
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
2 times, most recently
from
b8019a7 to
86e7107
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
2 times, most recently
from
65ec9a6 to
beb0ef0
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
beb0ef0 to
a93a760
Compare
|
@swift-ci please test |
compnerd
approved these changes
Mar 5, 2022
…on structures at runtime.
grynspan
force-pushed
the
jgrynspan/copy-metadata-sections
branch
from
a93a760 to
8451822
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exported symbol on non-Apple platforms to enumerate MetadataSection structures at runtime.
On Apple platforms, it is possible to enumerate the loaded metadata section structures of a process using dyld API. This is useful when, for example, looking up types that conform to a specific protocol (as might be done by e.g. swift-argument-parser.)
On non-Apple platforms, it is not possible to look up these structures because their addresses are not exported. The structures are instead statically declared and, when an image is loaded, are ingested by
swift_addNewDSOImage()(by way of static constructors emitted during compilation.)The end result is that there is no way, even when leveraging deep knowledge of the Swift ABI, to examine loaded Swift metadata on non-Apple platforms. This PR adds an exported function to the runtime named
swift_copyAllMetadataSections(). This function returns a C array ofswift::MetadataSectionsstructures. Client code can then call this function and inspect the resulting structures as needed.