Skip to content

[Concurrency] Avoid redundant conformance warning on Actor #42093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

[Concurrency] Avoid redundant conformance warning on Actor #42093

merged 1 commit into from
Mar 30, 2022
+1 −1

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 30, 2022

Since the Actor type is now Sendable via AnyActor:

/Users/ktoso/code/swift-project/swift/stdlib/public/Concurrency/Actor.swift:38:34: warning: redundant conformance constraint 'Self' : 'Sendable'
public protocol Actor: AnyActor, Sendable {
                                 ^
/Users/ktoso/code/swift-project/swift/stdlib/public/Concurrency/Actor.swift:38:24: note: conformance constraint 'Self' : 'Sendable' implied here
public protocol Actor: AnyActor, Sendable {
                       ^

@ktoso
[Concurrency] Avoid redundant conformance warning on Actor
84347e5 
Since the `Actor` type is now `Sendable` via `AnyActor`:

```
/Users/ktoso/code/swift-project/swift/stdlib/public/Concurrency/Actor.swift:38:34: warning: redundant conformance constraint 'Self' : 'Sendable'
public protocol Actor: AnyActor, Sendable {
                                 ^
/Users/ktoso/code/swift-project/swift/stdlib/public/Concurrency/Actor.swift:38:24: note: conformance constraint 'Self' : 'Sendable' implied here
public protocol Actor: AnyActor, Sendable {
                       ^
```
@ktoso
Copy link
Contributor Author

ktoso commented Mar 30, 2022

@swift-ci please test

@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor labels Mar 30, 2022
@ktoso ktoso requested a review from DougGregor March 30, 2022 04:07
@ktoso ktoso merged commit 4bde3ba into main Mar 30, 2022
@ktoso ktoso deleted the ktoso-patch-11 branch March 30, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktoso @DougGregor