SILGen: Emit async let entry points at correct abstraction level. #42101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jckarter
force-pushed
the
async-let-reabstraction
branch
from
08adbfb to
cf128ee
Compare
|
@swift-ci Please test |
Avoid a reabstraction thunk every time an async let entry point is emitted, by setting the context abstraction level while we emit the implicit closure. Adjust some surrounding logic that breaks when we do this: - When lowering a non-throwing function type against a throwing abstraction pattern, include the error type in the lowered substituted type. Async throwing and nonthrowing functions would require another thunk to convert away the throwingness of the async context, which would defeat the purpose. - Adjust the code in IRGen that pads the initial context size for `async let` entry points so that it works when the entry point has not yet emitted, by marking the async function pointer to be padded later if it isn't defined yet.
jckarter
force-pushed
the
async-let-reabstraction
branch
from
cf128ee to
d451203
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a reabstraction thunk every time an async let entry point is emitted,
by setting the context abstraction level while we emit the implicit closure.
Adjust some surrounding logic that breaks when we do this:
pattern, include the error type in the lowered substituted type. Async
throwing and nonthrowing functions would require another thunk to convert
away the throwingness of the async context, which would defeat the purpose.
async letentry points so that it works when the entry point has not yet emitted, by
marking the async function pointer to be padded later if it isn't defined
yet.