Provide the '@escaping' fix-it for any call-site escaping mismatch. #4242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wiftlang#4181) ...not just those where the functions match otherwise. This allows the fix-it to be provided in cases where the closure being passed is a subtype, or when there are generics involved. Yes, the '@escaping' might not be the only issue, but it will need to get fixed, and probably independently of anything else that's going on (except perhaps calling the wrong function). rdar://problem/27729540 (cherry picked from commit 148e25d)
|
@swift-ci Please test |
|
Unrelated LLDB test failure, but for maximum confidence we'd want to test again. |
milseman
referenced
this pull request
Aug 13, 2016
This makes the special case diagnostics for detecting a missing @escaping read through Optional and IUOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@escaping, even if they have nothing else in common.@escaping.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.