Change the signature of _swift_withWin32DbgHelpLibrary() to not use std::function (which is not ABI-safe in C functions.)
#42582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::function (which is not ABI-safe in C functions.)
|
@swift-ci please test |
mikeash
approved these changes
Apr 22, 2022
I mean, less "find" and more "I did it wrong to start with." 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the signature of
_swift_withWin32DbgHelpLibrary()to not usestd::function(which is not ABI-safe in C functions.) This change only affects Windows.Nothing outside the Swift repo is using this function, so it should not present an ABI-breaking change. The existing signature is still usable by way of a
static inlinefunction, so no call sites in the repo need changes.