Allow 'Any' as an IBAction's sender and an IBOutlet's type. (#4320) #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g#4320) With id-as-Any, /existing/ IBAction methods that have unconstrained sender parameters are being imported as taking 'Any?', and those methods then can't be overridden in Swift. We still don't allow arbitrary bridgeable types for IBActions and IBOutlets. This makes enough sense for value types, but might get us into trouble with swift_newtype at some point. rdar://problem/27853737 (cherry picked from commit ed01f89)
|
@swift-ci Please test OS X platform |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBActionandIBOutletattributes are used to identify members made available to Interface Builder. The compiler does some basic sanity checking on the types of these members to keep people from making obvious mistakes; unfortunately those checks were never updated for id-as-Any (SE-0116). This is mostly okay (you can still useAnyObject), but not when the method you want to mark as an action is also an override.AnyorAny?. Uses existing code paths for everything else.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.