[FixCode] Add diagnosis/fixit to help users deal with BooleanType's removal #4392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoval. Due to migration reasons, types used to conform to BooleanType, which must contain a member var 'boolValue', now does not convert to Bool. This patch adds a specific diagnosis/fixit to explicitly invoke 'boolValue' to please the context types.
|
@swift-ci test macOS |
|
Build failed |
|
LGTM. |
|
Do you think we can also handle this case as well:
This gives |
|
@swift-ci Please smoke test |
|
@akyrtzi Did we see this case in actual codebase? |
| // tries to add a specific diagnosis/fixit to explicitly invoke 'boolValue'. | ||
| if (toType->isBool()) { | ||
| auto LookupResult = CS->TC.lookupMember(CS->DC, fromType, | ||
| DeclName(CS->DC->getASTContext().getIdentifier("boolValue"))); |
There was a problem hiding this comment.
CS->TC.Context gets there a little faster.
|
This is rdar://problem/27894712, BTW, if not other Radars as well. |
|
@swift-ci Please smoke test |
|
@jrose-apple Comments addressed! |
|
@swift-ci Please smoke test |
|
@swift-ci Please test OS X platform |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.