Skip to content

Sema: Record Hashable conformance as used when emitting AnyHashableErasureExpr (3.0) #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2016
Merged

Sema: Record Hashable conformance as used when emitting AnyHashableErasureExpr (3.0) #4396

merged 1 commit into from
Aug 19, 2016

Conversation

slavapestov
Copy link
Contributor

  • Explanation: When constructing AST for a coercion to AnyHashable, we neglected to mark the conformance as used, which could lead to a link failure due to a missing symbol.
  • Scope of issue: Affects anyone using the new AnyHashable type, or dictionaries containing AnyHashable as keys.
  • Risk: Low
  • Radar: rdar://problem/27895165

@slavapestov slavapestov added this to the Swift 3.0 milestone Aug 19, 2016
@slavapestov
Copy link
Contributor Author

@swift-ci Please test os x

@slavapestov
Copy link
Contributor Author

@jckarter Do you mind reviewing this PR?

@jrose-apple
Copy link
Contributor

LGTM if Joe doesn't get to it.

@jckarter
Copy link
Contributor

LGTM too. Thanks Slava!

@tkremenek tkremenek merged commit 6281861 into swiftlang:swift-3.0-branch Aug 19, 2016
@slavapestov slavapestov deleted the fix-missing-conformance-anyhashable-3.0 branch August 20, 2016 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tkremenek tkremenek

Labels
None yet
Projects
None yet
Milestone
Swift 3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@slavapestov @jrose-apple @jckarter @tkremenek