Fix a bug related to the opened archetypes tracking #4639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Important: This PR should be merged after #4641 |
|
The build is broken because this change depends on a commit by @eeckstein, which is currently available on swift/master only. @eeckstein will submit a PR for swift-3.0-branch soon. |
|
I'm typing too fast ;-) One of the previous messages should have been read as: Important: This PR should be merged before #4641 |
If a SILBuilder creates a new instruction based on an old instruction and a new instruction is supposed to use some opened archetypes, one needs to set a proper opened archetypes context in the builder based on the opened archetypes used by the old instruction. This fixes rdar://28024272
swiftix
force-pushed
the
swift-3.0-branch-rdar-28024272
branch
from
2a229df to
226e4a7
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@tkremenek All tests are green. It can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
––– CCC Information –––
• Explanation: It is a correctness fix for opened archetypes tracking.
• Scope of Issue: Compiler crash reported by Dave Abrahams
• Origination: rdar://problem/28024272
• Risk: Pretty low. It fixes some cases which would result in a compiler crash. No new functionality is added.
• Reviewed By: Erik Eckstein
• Testing: Verified locally and using a CI @please test
• Directions for QA: No special directions. The patch includes unit tests.
Detailed description
If a SILBuilder creates a new instruction based on an old instruction and a new instruction is supposed to use some opened archetypes, one needs to set a proper opened archetypes context in the builder based on the opened archetypes used by the old instruction.
This fixes rdar://28024272