[SILGen] Restore old logic for checking (non-)zero error results. #4693
+78
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iftlang#4681) Actually bridging ObjCBool to Bool is overkill for this, but moreover it caused problems for non-boolean types that took this code path. Just go back to the previous logic of unwrapping multiple levels of struct; this way we can also handle wrappers around integer types (if we ever have any). rdar://problem/27985744 (cherry picked from commit a335ebc)
|
@swift-ci Please test |
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__attribute__((swift_error(zero_result)))by making a part of its implementation assume it would only be used with boolean values (it also supports integers); this resulted in assertion failures in debug builds of the compiler and incorrect run-time behavior (failing to identify errors) in release builds. The breakage was part of a general change to better handle boolean values in SIL, but this part of it wasn't fully correct and turned out to not be necessary. Revert back to the older way of doing things when dealing with imported throwing functions.