Skip to content

Conversation

PatrickPijnappel
Copy link
Contributor

Proposal to remove explicit usage of Optional<T> enum cases for consistency and reduced clutter (SR-212).

  • The SIL for both forms is identical.
  • Optional<T> takes precedence over other nil literal convertibles.
  • Optional.swift and ImplicitlyUnwrappedOptional.swift still use explicit forms.
  • All test pass (didn't run validation tests yet though).

@gribozavr
Copy link
Contributor

@PatrickPijnappel Did you run the tests? Just making sure. The change LGTM.

@PatrickPijnappel
Copy link
Contributor Author

@gribozavr Ran the normal tests before, just completed the validation tests now also. All looking good.

gribozavr added a commit that referenced this pull request Dec 13, 2015
[stdlib] Replace `.Some(x)` and `.None` by `x` and `nil`, respectively
@gribozavr gribozavr merged commit 0cf9b3e into swiftlang:master Dec 13, 2015
@PatrickPijnappel PatrickPijnappel deleted the implicit-optionals branch December 13, 2015 03:58
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
…ui-5.3

Un-XFAIL ACHNBrowserUI in debug configuration (5.3 branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants