Fix for ToolchainTestCase failure on non-FreeBSD systems #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need someone from Apple to kick off the tests and verify if this can be accepted. @jrose-apple, would you be able to help? Thanks. |
|
Seems all right to me. @swift-ci Please test |
|
Just wanted to see if we can get this merged. I can create another PR for master. |
|
Aack, sorry to lose this. @najacque, @tkremenek, is it okay to land this change on the older release branch, just to help testing? |
|
Yes. |
|
Thanks, Ted! And Vivian, please do create a PR for master, and I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolchainTestCase tried to instantiate every toolchain even when it isn't the current platform. This failed on SLES 12 where
sysctl -n kern.osreldateresulted in error. For the FreeBSD toolchain, we can check whether we are on FreeBSD before we call_release_date.Resolves SR-1838.
Tagging @ddunbar for his attention. Thanks.