[CSClosure] (Mostly NFC) Renames and introduction of AnyFunctionRef
#58423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SyntacticElement` represents a statement, pattern, declaration, condition, or expression and could originate from i.e. a closure, a function or a result builder body.
…ctionRef` Closure constraint generator has been renamed to `SyntacticElementGenerator` and can now handle both closure and function bodies.
…ctionRef` Closure solution application has been renamed to `SyntacticElementSolutionApplication` and can now handle both closure and function bodies.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
hborla
approved these changes
Apr 27, 2022
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 3, 2022
Cherry-pick of swiftlang#58423 This is one more step toward type-checking result builder bodies using conjunctions. The changes rename `ClosureBodyElement` to `SyntacticElement` to indicate that contained element could come from not just closure but a function body as well. Both constraint generator and solution application walkers have been renamed as well, and switched to use `AnyFunctionRef` instead of `ClosureExpr`.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 3, 2022
Cherry-pick of swiftlang#58423 The changes rename `ClosureBodyElement` to `SyntacticElement` to indicate that contained element could come from not just closure but a function body as well. Both constraint generator and solution application walkers have been renamed as well, and switched to use `AnyFunctionRef` instead of `ClosureExpr`.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 3, 2022
Cherry-pick of swiftlang#58423 The changes rename `ClosureBodyElement` to `SyntacticElement` to indicate that contained element could come from not just closure but a function body as well. Both constraint generator and solution application walkers have been renamed as well, and switched to use `AnyFunctionRef` instead of `ClosureExpr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one more step toward type-checking result builder bodies using conjunctions.
The changes rename
ClosureBodyElementtoSyntacticElementto indicate thatcontained element could come from not just closure but a function body as well.
Both constraint generator and solution application walkers have been renamed as well,
and switched to use
AnyFunctionRefinstead ofClosureExpr.