[5.7][LookupVisibleDecls] Implement shadowing for unqualified lookups #58530
+506
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
Tweaked usable check:
* Local type/func decls are usable even before declaration
* Outer nominal Instance member are not usable
* Type context cannot close over values in outer type contexts
Added shadowing rule by the base name:
* Type members don't shadow each other as long as they are in the
same type context.
* Local values shadow everything in outer scope
* Except that 'func' decl doesn't shadow 'var' decl if they are in the
same scope.
rdar://86285396
(cherry picked from commit eade9b7)
rintaro
force-pushed
the
5.7-ide-completion-shadowing-rdar86285396
branch
from
9a48d05 to
1f56100
Compare
|
@swift-ci Please test |
airspeedswift
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #58512 into
release/5.7lookupVisibleDecls()function used by code completion is supposed to return all visible and usable declarations. It used to have several issues, such as local types/funcs declared after the code completion point weren't reported despite they are usable, unusable instance members in outer type context were reported, unusable local values outside the current type context were reported, and the name shadowing wasn't implemented. Especially, the lack of shadowing results duplicated code completion entries, for example, inif let user = user { <HERE> }, both the outeruser: User?and the inneruser: Userwere reported, which was confusing. This change resolves those issues, so that code completion can provide more accurate results.primary-expressionandtype-identifier)