Skip to content

[5.7][CodeCompletion] Suggest 'actor' decl introducer keyword #58873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 12, 2022

Cherry-pick #58698 into release/5.7

  • Explanation: Previously 'actor' keyword was suggested as (deprecated) 'actor' decl modifier, and it was gated by '-enable-experimental-concurrency' compiler argument. Add 'actor' as a type decl introducer. This causes duplicated 'actor' in code completion if '-enable-experimental-concurrency', but that option is basically useless at this point, so I assume not many people is using it. Also 'actor' as a modifier will be removed soon.
  • Scope: Code completion
  • Risk: Low
  • Issues: [“actor” contextual keyword is never suggested #58520] rdar://92511769
  • Testing: Added regression test cases
  • Reviewer: Alex Hoppen (@ahoppen)

Previously 'actor' keyword was suggested as (deprecated) 'actor' decl
modifier, and it was gated by '-enable-experimental-concurrency'
compiler argument.
Add 'actor' as a type decl introducer. This causes duplicated 'actor' in
code completion if '-enable-experimental-concurrency', but that option
is basically useless at this point, so I assume not many people is using
it. Also 'actor' as a modifier will be removed soon.

[swiftlang#58520] rdar://92511769

(cherry picked from commit 2805864)
@rintaro rintaro requested a review from a team as a code owner May 12, 2022 19:01
@rintaro
Copy link
Member Author

rintaro commented May 12, 2022

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jun 2, 2022

@swift-ci Please test

@rintaro rintaro merged commit c4c214d into swiftlang:release/5.7 Jun 3, 2022
@rintaro rintaro deleted the 5.7-ide-completion-rdar92511769 branch June 3, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants