[cxx interoperability] Turn off non subscript templated operators #59207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
NSAntoine
reviewed
Jun 1, 2022
lib/ClangImporter/ClangImporter.cpp
Outdated
| #include <memory> | ||
| #include <string> |
There was a problem hiding this comment.
I assume the double inclusion of the string header is a mistake?
There was a problem hiding this comment.
This is from a different PR (which Im branched off of) but this is a good catch thanks!
There was a problem hiding this comment.
Addressing in this PR actually since this is a follow up and cleaning up this include is fine here I think
|
@swift-ci please smoke test |
Huddie
force-pushed
the
update-cxx-operator-impl-templates-off
branch
from
6532e6d to
0d7a041
Compare
|
@swift-ci please smoke test |
zoecarver
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've updated how CXX operators get imported into swift. We don't currently support templated operators aside from the subscript operator.