[5.7][capture-promotion] Add support for GEPs from captures that are load_borrowed. #59255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…borrowed. We supported this code pattern previously just for loads and never implemented the support for load_borrow. I just added analogous code for load_borrow. Without this, we hit a crash since: 1. We would not process the struct_element_addr for a valid value. 2. The load_borrow would not look through the struct_element_addr, so we would ask the cloner for the mapped value to the struct_element_addr... it was never visited, thus never mapped, thus KABOOM. rdar://93879907 (cherry picked from commit 3b39af3)
|
@swift-ci test |
meg-gupta
approved these changes
Jun 3, 2022
tbkka
approved these changes
Jun 3, 2022
gottesmm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We supported this code pattern previously just for loads and never implemented
the support for load_borrow. I just added analogous code for
load_borrow. Without this, we hit a crash since:
ask the cloner for the mapped value to the struct_element_addr... it was never
visited, thus never mapped, thus KABOOM.
rdar://93879907
(cherry picked from commit 3b39af3)