[move-only] Two small fixes #59303
Merged
[move-only] Two small fixes #59303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a friend so we can invoke that method. The only place outside of SILType that uses getRawASTType() is in SILPrinter. It is really an inner detail of SILType that we don't want to expose. With that in mind, in this commit we: 1. Made SILType::getRawASTType() private. 2. Forward declared SILPrinter in SILType.h. We don't define it so no one can use it, but the declaration still lets us make it a friend class of SILType (allowing SILPrinter to still access getRawASTType()).
…e explicitly about move only wrapper and not move only itself. Specifically: * isMoveOnly() -> isMoveOnlyWrapped() * asMoveOnly() -> addingMoveOnlyWrapper() * withoutMoveOnly() -> removingMoveOnlyWrapper() * copyMoveOnly() -> copyingMoveOnlyWrapper() This is just pure renaming to resolve confusion from the reader.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, in the first commit, I make SILType::getRawASTType() private. We don't want people touching the Raw AST Type directly. That is a breakage in the abstraction. Second, I renamed some of the move only wrapper APIs to have move only wrapper instead of just move only in the name. This prevents some confusion that we saw in the other PR.