🍒[5.7][Distributed] Fix too restrictive distributed witness isolation checking #59397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
|
@swift-ci please test |
DougGregor
approved these changes
Jun 14, 2022
|
Thank you for reviews! |
|
@swift-ci please build toolchain macOS |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Witness checking is too restrictive for distributed actors conforming to protocols which are already
DistributedActorconstrained. Long discussion of this in #59358 but short version is that this is too restrictive and prevents some APIs, and generally is an omission in the isolation model.Risk: Low, fixes missing ability to conform to DistributedActor constrained protocols from distributed actors. Does not affect any other parts of library or runtime.
Review by: @DougGregor
Testing: PR Testing, Verifying using custom toolchain in Cluster library.
Radar: rdar://94779780
Original PR: #59358
Unblocks: apple/swift-distributed-actors#961