[cxx-interop] Synthesize conformances to UnsafeCxxInputIterator
#60001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need to add more tests. |
|
@swift-ci please smoke test |
zoecarver
approved these changes
Jul 11, 2022
egorzhdan
force-pushed
the
egorzhdan/synthesize-iterator-conformance
branch
2 times, most recently
from
a0a02ab to
6d7f03f
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/synthesize-iterator-conformance
branch
2 times, most recently
from
bebaf33 to
727606e
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/synthesize-iterator-conformance
branch
from
727606e to
f73b027
Compare
|
@swift-ci please smoke test |
egorzhdan
commented
Jul 18, 2022
| return; | ||
|
|
||
| // Check if present: `func ==` | ||
| // FIXME: this only detects `operator==` declared as a member. |
There was a problem hiding this comment.
I will address this in a separate patch.
There was a problem hiding this comment.
If you define bool operator==(const A& lhs, const A& rhs) out of the class definition, the lookup won't find this decl (which is OK, we just need to handle it differently here)
egorzhdan
force-pushed
the
egorzhdan/synthesize-iterator-conformance
branch
from
f73b027 to
0c3edb8
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
This teaches ClangImporter to synthesize conformances of C++ iterator types to `UnsafeCxxInputIterator` protocol from the `Cxx` module. We consider a C++ type to be an iterator if it defines a subtype (usually a typedef or a using decl) called `iterator_category` that inherits from `std::input_iterator_tag`. rdar://96235368
egorzhdan
force-pushed
the
egorzhdan/synthesize-iterator-conformance
branch
from
0c3edb8 to
d85d2e9
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This teaches ClangImporter to synthesize conformances of C++ iterator types to
UnsafeCxxInputIteratorprotocol from theCxxmodule.We consider a C++ type to be an iterator if it defines a subtype (usually a typedef or a using decl) called
iterator_categorythat inherits fromstd::input_iterator_tag.rdar://96235368