SILGen: Drop value argument when lowering Builtin.sizeof/alignof/strideof #60252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jckarter
force-pushed
the
silgen-no-sizeof-value-argument
branch
from
6c59950 to
783a1c4
Compare
|
@swift-ci Please test |
…deof. The metatype value isn't needed to do the memory layout computation, and IRGen only looks at the substitutions passed to the generic signature, so we can reduce SIL code size, and avoid leaving behind useless metadata accesses, if we don't emit it.
jckarter
force-pushed
the
silgen-no-sizeof-value-argument
branch
from
783a1c4 to
24158b2
Compare
|
@swift-ci Please test |
|
@jckarter, it appears you committed an executable called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metatype value isn't needed to do the memory layout computation, and
IRGen only looks at the substitutions passed to the generic signature, so
we can reduce SIL code size, and avoid leaving behind useless metadata
accesses, if we don't emit it.