Skip to content

[test] modify to be compatible with minimal stdlib #60309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jul 29, 2022

  • validate that unaligned loads work for types with large alignments
  • in the minimal stdlib, only Builtin types can be used for this

This is a better fix for rdar://97029576, improving on #60061

@glessard glessard requested a review from atrick July 29, 2022 15:45
@glessard glessard force-pushed the rdar97029576-minimal-stdlib branch 3 times, most recently from 9d11777 to 08d9058 Compare July 29, 2022 18:30
- validate that unaligned loads work for types with large alignments
- in the minimal stdlib, only `Builtin` types can be used for this
@glessard glessard force-pushed the rdar97029576-minimal-stdlib branch from 08d9058 to a9a740d Compare July 29, 2022 18:31
@glessard
Copy link
Contributor Author

glessard commented Aug 1, 2022

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@glessard glessard marked this pull request as ready for review August 1, 2022 21:18
@glessard
Copy link
Contributor Author

glessard commented Aug 1, 2022

@swift-ci please test and merge

@glessard
Copy link
Contributor Author

glessard commented Aug 1, 2022

@swift-ci please test macOS platform

@glessard
Copy link
Contributor Author

glessard commented Aug 1, 2022

@swift-ci please test Windows platform

@glessard glessard merged commit db7d1e7 into swiftlang:main Aug 3, 2022
@glessard glessard deleted the rdar97029576-minimal-stdlib branch August 3, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants