[Sema] Warn about dictionary literal of dictionary type about duplicated keys #60479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
xedin
reviewed
Aug 11, 2022
LucianoPAlmeida
force-pushed
the
dictionary-literal
branch
from
739a6f8 to
f3cb449
Compare
LucianoPAlmeida
force-pushed
the
dictionary-literal
branch
3 times, most recently
from
054baa4 to
2d1bcd2
Compare
xedin
approved these changes
Aug 15, 2022
LucianoPAlmeida
force-pushed
the
dictionary-literal
branch
2 times, most recently
from
c9c7324 to
30049fc
Compare
LucianoPAlmeida
force-pushed
the
dictionary-literal
branch
from
30049fc to
4186214
Compare
LucianoPAlmeida
force-pushed
the
dictionary-literal
branch
from
4186214 to
1b7b6a3
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply warns about dictionary literal with duplicated keys only when they are inferred as
Dictionarywhere we know duplicated keys are not stored, but we cannot diagnose the same for other customExpressibleByDictionaryLiteraltype because rules are unknown.Resolves #43258.