Skip to content

[5.7.0][incrParse] Encode Unicode characters in command output if stdout doesn't support Unicode #60676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2022
Merged

[5.7.0][incrParse] Encode Unicode characters in command output if stdout doesn't support Unicode #60676

merged 1 commit into from
Aug 20, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 20, 2022 •
edited
Loading

Cherry-pick #42525 to release/5.7.0.

@ahoppen
[incrParse] Encode Unicode characters in command output if stdout doe…
2bd9877 
…sn't support Unicode

In verbose mode incrparse/test_util.py outputs the commands it executes to stdout. Since these commands contain Unicode emojis, it fails if stdout doesn't support Unicode. In these cases, encode the Unicode characters to their escape sequence.

rdar://92047111
@ahoppen ahoppen requested a review from a team as a code owner August 20, 2022 12:26
@ahoppen
Copy link
Member Author

ahoppen commented Aug 20, 2022

@swift-ci Please test

@ahoppen ahoppen changed the title [incrParse] Encode Unicode characters in command output if stdout doe… [5.7.0][incrParse] Encode Unicode characters in command output if stdout doe… Aug 20, 2022
@ahoppen ahoppen added the r5.7 label Aug 20, 2022
@ahoppen ahoppen changed the title [5.7.0][incrParse] Encode Unicode characters in command output if stdout doe… [5.7.0][incrParse] Encode Unicode characters in command output if stdout doesn't support Unicode Aug 20, 2022
@ahoppen ahoppen added this to the Swift 5.7 milestone Aug 20, 2022
@tkremenek tkremenek merged commit 6b714a3 into swiftlang:release/5.7.0 Aug 20, 2022
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 5.7

Projects

None yet

Milestone

Swift 5.7

Development

Successfully merging this pull request may close these issues.

3 participants

@ahoppen @tkremenek @AnthonyLatsis