CallerAnalysis: be more tolerant about missing FunctionInfos #60998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, the analysis invalidation notifications should assure that every function has a CallerAnalysis::FunctionInfo in `funcInfos`. But it's not unlikely that we are missing some of those notifications. We got some not-reproducible crash reports because of missing function infos in CallerAnalysis. With this change the analysis accepts missing function infos and does the right thing if such an info is missing. In the long term we should replace CallerAnalysis by FunctionUses, anyway. rdar://99653954
|
@swift-ci test |
|
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, the analysis invalidation notifications should assure that every function has a CallerAnalysis::FunctionInfo in
funcInfos. But it's not unlikely that we are missing some of those notifications. We got some not-reproducible crash reports because of missing function infos in CallerAnalysis. With this change the analysis accepts missing function infos and does the right thing if such an info is missing.In the long term we should replace CallerAnalysis by FunctionUses, anyway.
rdar://99653954