Skip to content

[Dependency Scanner] Add API to query emitted diagnostics during a scan #60999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 8, 2022

Adds a simple, opaque API to libSwiftScan to query the scanner's diagnostics emitted so far.

This is accomplished by the DependencyScanningTool keeping around a new DependencyScannerDiagnosticCollectingConsumer which collects all diagnostics emitted during a scan. Also adds an API to clear the collected-so-far diagnostics by clients.

@artemcm
Copy link
Contributor Author

artemcm commented Sep 8, 2022

API exercised and tested in swiftlang/swift-driver#1174

@artemcm artemcm requested a review from nkcsgexi September 8, 2022 16:36
@artemcm
Copy link
Contributor Author

artemcm commented Sep 8, 2022

@artemcm
Copy link
Contributor Author

artemcm commented Sep 8, 2022

swiftlang/swift-driver#1174
@swift-ci test Windows platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Sep 9, 2022

swiftlang/swift-driver#1174
@swift-ci test Windows platform

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@artemcm artemcm merged commit 3211b93 into swiftlang:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants