Fix Mem2Reg check on end_borrows of store_borrow #61006
Merged
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking if the end_borrow is ending the lifetime of the store_borrow of the asi under consideration, this code was checking if the store_borrow source is the runningValue which is incorrect in cases where a store_borrow src to another destination gets replaced during mem2reg. This PR fixes the issue.
meg-gupta
force-pushed
the
fixmem2regbug
branch
from
a9f709f to
b472301
Compare
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if the end_borrow is ending the lifetime of the store_borrow of the asi under consideration, this code was checking if the store_borrow source is the runningValue which is incorrect in cases where a store_borrow src to another destination gets replaced during mem2reg. This PR fixes the issue.