IRGen: fix how metadata is loaded for fast class casting #61219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
eeckstein
force-pushed
the
fix-fast-class-casting
branch
from
f4a8350 to
9b38178
Compare
|
@swift-ci test |
Pass the correct type to `emitHeapMetadataRefForHeapObject()`. Fixes a runtime crash in case a class protocol is cast to a final swift class, where the actual object is an ObjectiveC class instance. rdar://99626888
eeckstein
force-pushed
the
fix-fast-class-casting
branch
from
9b38178 to
2527d37
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the correct type to
emitHeapMetadataRefForHeapObject(). Fixes a runtime crash in case a class protocol is cast to a final swift class, where the actual object is an ObjectiveC class instance.rdar://99626888