[Threading][Tests] Don't test timeouts on threading=none. #61411
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preprocessor condition stopping tests from running for threading=none was in slightly the wrong place. rdar://100707643
|
@swift-ci Please smoke test and merge |
|
preset=buildbot_incremental_linux_crosscompile_wasm |
|
@kateinoigakukun I think the WASM preset test failed for an unrelated reason. I'm pretty sure that this change will fix the problem that you reported though. |
kateinoigakukun
approved these changes
Oct 3, 2022
|
@al45tair Yes, the test failure of Runtime one is another issue. Threading tests now passed, so it's fine to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preprocessor condition stopping tests from running for
threading=nonewas in slightly the wrong place.rdar://100707643