-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix inconsistencies with isolated
parameters.
#61862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
ktoso
reviewed
Nov 2, 2022
ktoso
reviewed
Nov 2, 2022
ktoso
reviewed
Nov 2, 2022
Looking good so far! I am confused about: |
46fd8e2
to
3e93923
Compare
Resolves #60474 |
@swift-ci please test |
df6f8ea
to
ae6686c
Compare
This covers function types, closures, and function declarations: - only one `isolated` parameter - no global-actor + `isolated` parameter - no `nonisolated` + `isolated`. all diagnostics are warnings until Swift 6
ae6686c
to
3b3bdaf
Compare
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subsumes #60483
There are a whole bunch of ways the rules about
isolated
parameters are either not being enforced, or the wrong isolation is being used for such functions. This PR tries to sharpen the definition and rules so they make sense.TODOs:
TypeChecker::checkParameterList
fix isolation fordeferred.subscript
(seems to default to nonisolated)make sure isolation for initializers is working / covered (doesn't check isolation at all?)deferred.resolves rdar://100039019