[interop][SwiftToCxx] add support for exposing non-isolated actor declarations #61882
Conversation
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
|
||
| public nonisolated func method() { | ||
| print("nonisolated method") | ||
| } |
There was a problem hiding this comment.
I wonder if you'd also want to add a
public nonisolated func methodAsync() async
and confirm it does not import; though I guess this perhaps is already handled -- it's the same as any normal async function after all.
There was a problem hiding this comment.
async functions are not bridged already, we cover that. But I can add as a follow-up!
| distributed public func dist() {} | ||
|
|
||
| @_expose(Cxx) // ok | ||
| public init() { |
There was a problem hiding this comment.
| public init() { | |
| public init(actorSystem: LocalTestingDistributedActorSystem) { | |
| self.actorSystem = actorSystem |
is what you'd need to do to make sure this is a 100% correct actor; this should have failed to compile tbh as it is declared now - but the other errors probably prevented it from going into those checks
There was a problem hiding this comment.
Sounds good, I'll commit this as a follow-up!
| } | ||
|
|
||
| @_expose(Cxx) | ||
| public distributed actor DistributedActorClass { |
There was a problem hiding this comment.
Hooray! Semantics look good 👍
| return {Unsupported, UnrepresentableActorClass}; | ||
| } | ||
| if (getActorIsolation(const_cast<ValueDecl *>(VD)).isActorIsolated()) | ||
| return {Unsupported, UnrepresentableIsolatedInActor}; |
There was a problem hiding this comment.
awesome, glad that this indeed covered all the bases :-)
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
|
source compatibility suite failures are unrelated, will merge: |
This exposes Swift actor classes to C++. Only non-isolated declarations get bridged to C++ though.