Use the new side effect analysis in the performance inliner #62000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er type which contain raw pointers
We can ignore any memory writes in a program termination point, because it's not relevant for the caller. But we need to consider memory reads, otherwise preceeding memory writes would be eliminated by dead-store-elimination in the caller. E.g. String initialization for error strings which are printed by the program termination point. Regarding ownership: a program termination point must not touch any reference counted objects.
It was a wrong assumption that we can ignore effects in dead-end blocks.
…turn an allocated object There are examples of such functions, which were previously captured by `isPureCall` in the inliner. But the implementation of `isPureCall` was wrong. With the new (and correct) side effect analysis we need to correctly handle such functions in the inlining heuristic.
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of replacing the old escape- and side-effect analysis. The second part is here: #61715
The inliner uses side-effect analysis to check if a function is a pure function (used for the inlining heuristics).
This PR also contains a few bug fixes for the ComputeSideEffects pass.