update_checkout: re-read config for cross-repo testing #62004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
When updating versions of some dependencies, it's important to be able to re-read the checkout config to get the new versions to actually check them out.
MaxDesiatov
force-pushed
the
maxd/fix-checkout-cross-repo
branch
from
bd4588d to
fc3e14b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
shahmishal
approved these changes
Nov 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
MaxDesiatov
force-pushed
the
maxd/fix-checkout-cross-repo
branch
from
825f078 to
74613a7
Compare
|
@swift-ci please smoke test |
MaxDesiatov
force-pushed
the
maxd/fix-checkout-cross-repo
branch
from
74613a7 to
9d29995
Compare
MaxDesiatov
added a commit
that referenced
this pull request
Nov 11, 2022
A one line follow-up fix for #62004. We re-read the config, but didn't check out correct branches after that, because `scheme_map` dictionary was loaded from the old config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating versions of some dependencies, it's important to be able to re-read the checkout config to get the new versions to actually check them out. This not working prevents us from making CI green in cross-repo PRs that update these dependencies.
I also used this as an opportunity to refactor out some common code and add Python docstrings to some functions for easier maintenance.