[IDE] Rename CodeCompletion to IDEInspection in cases where the code path no longer exclusively applies to code completion #62522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
CodaFi and
DougGregor
as code owners
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/rename-completion
branch
from
0dced76 to
c6de4a9
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Dec 12, 2022
| @@ -1,4 +1,4 @@ | |||
| //===--- CodeCompletionCallbacks.h - Parser's interface to code completion ===// | |||
| //===--- IDEInspectionCallbacks.h - Parser's interface to code completion ===// | |||
There was a problem hiding this comment.
code completion
Not true any more 😅
rintaro
approved these changes
Dec 12, 2022
…path no longer exclusively applies to code completion The code completio infrastructure is also being used for cursor info now, so it should no longer be called code completion. rdar://103251187
ahoppen
force-pushed
the
ahoppen/rename-completion
branch
from
c6de4a9 to
fe2ae72
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code completion infrastructure is also being used for cursor info now, so it should no longer be called code completion.
rdar://103251187