[ConstraintSystem] Enable pack element type reprs in expressions. #62713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traint when resolving pack reference type reprs inside pack expansion expressions.
…' type reprs to be pack expansion expressions.
…tType instead of assigning it to std::function_ref. std::function_ref does not own the function reference, so assigning an OpenPackElementType to a local function_ref lead to stale constraint system references when invoking operator () later on.
getUnopenedTypeOfReference.
that are expanded within the pattern.
…onstraints rather than relying on PackElementExprs collected by preCheck. This handles pack element expressions and pack element type reprs, and enforces that all packs expanded by a given pack expansion expression all have the same shape. Once the parser creates PackExpansionExpr directly (based on a dedicated syntax instead of postfix '...'), the code in preCheck for identifying and creating pack expansions can simply be deleted.
|
@swift-ci please smoke test |
… type resolution.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pack element type reprs in expressions by plumbing a callback through type resolution that will generate a
PackElementOfconstraint when resolving aPackReferenceTypeRepr. TheOpenPackElementTypefunction object is created during constraint generation, and ultimatelyTypeReprs andTypeExprs inside pack expansion expressions will have an opened pack element type. If such type reprs appear outside pack expansions, type resolution will report an error.