Skip to content

[Sema] Record specify contextual type for nil in placeholder context #63145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

[Sema] Record specify contextual type for nil in placeholder context #63145

merged 1 commit into from
Jan 24, 2023

Conversation

LucianoPAlmeida
Copy link
Contributor

Even in placeholder context, if the hole is on a locator that is anchored in a nil literal expression, let's record a specify contextual type for nil fix.

Resolves #63130

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

xedin
xedin approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xedin
Copy link
Contributor

xedin commented Jan 23, 2023

@swift-ci please test Windows platform

@LucianoPAlmeida LucianoPAlmeida merged commit 62bc0ea into swiftlang:main Jan 24, 2023
@LucianoPAlmeida LucianoPAlmeida deleted the nil-placeholders branch January 24, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad diagnostic for nil literal with contextual type of _
2 participants
@LucianoPAlmeida @xedin