SILOptimizer: add complexity limit in ARCCodeMotion and DeadStoreElimination #64320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ination Add an emergency exit to avoid bad compile time problems in rare corner cases. The introduced limit is more than enough for "real world" code. Even large functions have < 100 locations. But in some corner cases - especially in generated code - we can run into quadratic complexity for large functions without that limit. Fixes a compile time problem. Unfortunately I don't have isolated test cases for these problems. rdar://106516360
|
@swift-ci test |
|
@swift-ci benchmark |
atrick
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
No objections.
Ideally, optimizations would be designed to work on regions rather than functions, or to summarize locations rather than totally giving up.
If you already did some investigation of the max locations found in the SCK, it would be nice to mention that in the commit message.
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an emergency exit to avoid bad compile time problems in rare corner cases. The introduced limit is more than enough for "real world" code. Even large functions have < 100 locations. But in some corner cases - especially in generated code - we can run into quadratic complexity for large functions without that limit.
Fixes a compile time problem.
Unfortunately I don't have isolated test cases for these problems.
rdar://106516360